Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS-5995] - create mine report definitions #3413

Merged
merged 9 commits into from
Feb 14, 2025
Merged

[MDS-5995] - create mine report definitions #3413

merged 9 commits into from
Feb 14, 2025

Conversation

matbusby-fw
Copy link
Collaborator

Objective

  • Added modal to create mine report definitions that can then be linked to a compliance code
  • Added api endpoint and update to model to intake new definitions
  • Updated mine_report_definition.report_name to be unique
  • Added a get endpoint to get mine_report_definition_due_date_types (previously only accessed in the backend)

MDS-5995

image

@matbusby-fw
Add functionality to create mine report definitions.
ff9de0e 
Introduced a POST endpoint, state slice, and a modal form for creating mine report definitions. Updated UI components to support creating and managing compliance reports.
@matbusby-fw
Add new report definition functionality tests
b36993c
@matbusby-fw
update snaps
150bc31
@matbusby-fw matbusby-fw force-pushed the mds-5995-create-mine-report-definitions branch from fe99017 to 150bc31 Compare February 10, 2025 20:59
@matbusby-fw matbusby-fw marked this pull request as ready for review February 10, 2025 22:56
@matbusby-fw matbusby-fw added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Feb 10, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
72.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
63.4% Coverage on New Code (required ≥ 80%)
22.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
79.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matbusby-fw matbusby-fw requested a review from taraepp February 13, 2025 17:54
asinn134
asinn134 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@asinn134 asinn134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@matbusby-fw matbusby-fw merged commit 3b340ce into develop Feb 14, 2025
18 of 20 checks passed
@matbusby-fw matbusby-fw deleted the mds-5995-create-mine-report-definitions branch February 14, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taraepp taraepp taraepp approved these changes

@asinn134 asinn134 asinn134 approved these changes

@simensma-fresh simensma-fresh Awaiting requested review from simensma-fresh

@sggerard sggerard Awaiting requested review from sggerard

Assignees
No one assigned
Labels
👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matbusby-fw @taraepp @asinn134